Skip to content

Prevent discovered Tradfri while already configured#16891

Merged
balloob merged 2 commits intodevfrom
fix-tradfri-discovery-duplicate
Sep 26, 2018
Merged

Prevent discovered Tradfri while already configured#16891
balloob merged 2 commits intodevfrom
fix-tradfri-discovery-duplicate

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Sep 26, 2018

Description:

Prevent Tradfri config flow from being discovered when it is already configured.

Reported by Cogneato in the chat.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

assert len(mock_init.mock_calls) == 0


async def test_config_yaml_host_imported(hass):
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redefinition of unused 'test_config_yaml_host_imported' from line 28

@balloob balloob added this to the 0.79 milestone Sep 26, 2018
@balloob balloob merged commit 273a7af into dev Sep 26, 2018
@ghost ghost removed the in progress label Sep 26, 2018
@balloob balloob deleted the fix-tradfri-discovery-duplicate branch September 26, 2018 16:03
balloob added a commit that referenced this pull request Sep 27, 2018
* Prevent discovered Tradfri while already configured

* Lint
@balloob balloob mentioned this pull request Sep 28, 2018
@KRA77
Copy link
Copy Markdown

KRA77 commented Sep 29, 2018

I just updated to 0.79.0 - now I have 1 none responding light card, one light card where all devices are listed as unavailable. And one notification that says new devices discovered (tradfri)

I'm running hassos 1.11 and Supervisor 131, upgraded from 0.78.3

EDIT: Ran the discovery config and things are back to normal

@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants