Skip to content

Revert "Add Broadlink infrared emitter support to native infrared platform"#168717

Merged
justanotherariel merged 2 commits into
devfrom
revert-168385-broadlink-infrared-emitter
Apr 21, 2026
Merged

Revert "Add Broadlink infrared emitter support to native infrared platform"#168717
justanotherariel merged 2 commits into
devfrom
revert-168385-broadlink-infrared-emitter

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

Reverts #168385

Rationale for reverting:

  • The PR contains dead code
  • Some of the implementation should be in a separate library
  • The tests violate our standards

Copilot AI review requested due to automatic review settings April 21, 2026 13:59
@home-assistant home-assistant Bot added cla-signed has-tests integration: broadlink remove-platform small-pr PRs with less than 30 lines. Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage labels Apr 21, 2026
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @Danielhiversen, @felipediel, @L-I-Am, @eifinger, mind taking a look at this pull request as it has been labeled with an integration (broadlink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of broadlink can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign broadlink Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the previously-added Broadlink “infrared” platform support, returning the integration to its pre-#168385 state.

Changes:

  • Removes the Broadlink infrared platform module and its associated packet/command helpers.
  • Drops the Broadlink integration’s dependency on the infrared integration and removes related translation strings.
  • Removes the dedicated Broadlink infrared tests introduced by the reverted PR.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/components/broadlink/test_infrared.py Deletes tests that were added for the reverted Broadlink infrared platform implementation.
homeassistant/components/broadlink/strings.json Removes infrared entity naming and the IR send failure exception translation.
homeassistant/components/broadlink/manifest.json Removes the infrared dependency added by the reverted feature.
homeassistant/components/broadlink/infrared.py Deletes the Broadlink infrared entity/platform implementation and helpers.
homeassistant/components/broadlink/const.py Removes the Platform.INFRARED mapping and the IR packet repeat index constant.

@justanotherariel
Copy link
Copy Markdown
Member

There are conflicts

@justanotherariel justanotherariel marked this pull request as draft April 21, 2026 14:41
@emontnemery emontnemery marked this pull request as ready for review April 21, 2026 14:57
Copilot AI review requested due to automatic review settings April 21, 2026 14:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

@justanotherariel justanotherariel added code-quality and removed small-pr PRs with less than 30 lines. labels Apr 21, 2026
@justanotherariel justanotherariel merged commit 3500f0a into dev Apr 21, 2026
37 checks passed
@justanotherariel justanotherariel deleted the revert-168385-broadlink-infrared-emitter branch April 21, 2026 16:19
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed code-quality has-tests integration: broadlink Quality Scale: No score remove-platform Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants