Skip to content

Tibber realtime consumption, Tibber pulse#16870

Merged
Danielhiversen merged 5 commits intodevfrom
tibber_consumption
Sep 26, 2018
Merged

Tibber realtime consumption, Tibber pulse#16870
Danielhiversen merged 5 commits intodevfrom
tibber_consumption

Conversation

@Danielhiversen
Copy link
Copy Markdown
Member

@Danielhiversen Danielhiversen commented Sep 25, 2018 •
edited
Loading

Description:

Adds support for realtime consumption from Tibber

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6358

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: tibber
    access_token: d1007ead2dc84a2b82f0de19451c5fb22112f7ae11d19bf2bedb224a003ff74a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@ghost ghost assigned Danielhiversen Sep 25, 2018
@ghost ghost added the in progress label Sep 25, 2018
MartinHjelmare
MartinHjelmare reviewed Sep 25, 2018
View reviewed changes
Comment thread homeassistant/components/sensor/tibber.py
Comment thread homeassistant/components/sensor/tibber.py Outdated
def unique_id(self):
"""Return a unique ID."""
home = self._tibber_home.info['viewer']['home']
return home['meteringPointData']['consumptionEan'] + '_rt_consumption'
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare Sep 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use string formatting.

MartinHjelmare
MartinHjelmare approved these changes Sep 26, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can be merged when build passes.

@Danielhiversen Danielhiversen merged commit dc102a9 into dev Sep 26, 2018
@ghost ghost removed the in progress label Sep 26, 2018
@Danielhiversen Danielhiversen deleted the tibber_consumption branch September 26, 2018 05:49
@balloob balloob mentioned this pull request Oct 12, 2018
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

@Danielhiversen Danielhiversen

Labels

cla-signed integration: tibber

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Danielhiversen @MartinHjelmare @homeassistant