Skip to content

Correct state/device class for water in gardena#168637

Merged
erwindouna merged 1 commit into
home-assistant:devfrom
elupus:gardena/fix_state_class
Apr 20, 2026
Merged

Correct state/device class for water in gardena#168637
erwindouna merged 1 commit into
home-assistant:devfrom
elupus:gardena/fix_state_class

Conversation

@elupus
Copy link
Copy Markdown
Contributor

@elupus elupus commented Apr 20, 2026

Use water instead of volume to ensure this is allowable in energy dashboard and make sure we add measurement state class where applicable.

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

@elupus
Copy link
Copy Markdown
Contributor Author

elupus commented Apr 20, 2026

If it applies cleanly to last release it would be good to pick it, but no bigie if it's delayed.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Gardena Bluetooth integration’s water-related sensors so they use the correct sensor device/state classes, aligning them with Home Assistant’s water/energy dashboard validation rules.

Changes:

  • Switch flow total sensors from SensorDeviceClass.VOLUME to SensorDeviceClass.WATER.
  • Add SensorStateClass.MEASUREMENT where applicable (flow rate and spray distance).
  • Update snapshot expectations to reflect the new device/state class metadata.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
homeassistant/components/gardena_bluetooth/sensor.py Corrects water-related sensor metadata (device_class/state_class) for proper classification and statistics behavior.
tests/components/gardena_bluetooth/snapshots/test_sensor.ambr Updates snapshot outputs to match the new sensor capabilities/attributes.

Copy link
Copy Markdown
Member

@erwindouna erwindouna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elupus!

@erwindouna erwindouna merged commit e889541 into home-assistant:dev Apr 20, 2026
37 checks passed
@elupus elupus deleted the gardena/fix_state_class branch April 20, 2026 17:21
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants