Skip to content

Add Roborock fan speed validation and error handling#168623

Merged
edenhaus merged 1 commit into
home-assistant:devfrom
allenporter:roborock-validate-modes
Apr 21, 2026
Merged

Add Roborock fan speed validation and error handling#168623
edenhaus merged 1 commit into
home-assistant:devfrom
allenporter:roborock-validate-modes

Conversation

@allenporter
Copy link
Copy Markdown
Contributor

Proposed change

Add explicit validation on fan speed modes to limit to existing valid modes.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings April 20, 2026 14:16
@home-assistant home-assistant Bot added bugfix cla-signed has-tests integration: roborock small-pr PRs with less than 30 lines. Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage by-code-owner Quality Scale: silver labels Apr 20, 2026
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the Roborock vacuum integration by validating requested fan speed values and raising a user-friendly ServiceValidationError (instead of propagating lower-level errors) when an invalid fan speed is provided.

Changes:

  • Add explicit fan speed validation for the “V1” Roborock vacuum implementation by checking the fan speed against the device’s supported mapping.
  • Add explicit fan speed validation/error translation for the Q7 implementation by converting ValueError into ServiceValidationError.
  • Update/expand tests to verify invalid fan speed handling across multiple Roborock vacuum entity variants.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
homeassistant/components/roborock/vacuum.py Adds fan speed validation and consistent ServiceValidationError handling for invalid values.
tests/components/roborock/test_vacuum.py Adds a parameterized test ensuring invalid fan speeds raise ServiceValidationError for multiple entity types.

Copy link
Copy Markdown
Member

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @allenporter 👍

@edenhaus edenhaus merged commit f73f1df into home-assistant:dev Apr 21, 2026
37 checks passed
@edenhaus edenhaus added this to the 2026.4.4 milestone Apr 21, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix by-code-owner cherry-picked cla-signed has-tests integration: roborock Quality Scale: silver small-pr PRs with less than 30 lines. Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants