Add Roborock fan speed validation and error handling#168623
Merged
Merged
Conversation
Contributor
|
Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the Roborock vacuum integration by validating requested fan speed values and raising a user-friendly ServiceValidationError (instead of propagating lower-level errors) when an invalid fan speed is provided.
Changes:
- Add explicit fan speed validation for the “V1” Roborock vacuum implementation by checking the fan speed against the device’s supported mapping.
- Add explicit fan speed validation/error translation for the Q7 implementation by converting
ValueErrorintoServiceValidationError. - Update/expand tests to verify invalid fan speed handling across multiple Roborock vacuum entity variants.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| homeassistant/components/roborock/vacuum.py | Adds fan speed validation and consistent ServiceValidationError handling for invalid values. |
| tests/components/roborock/test_vacuum.py | Adds a parameterized test ensuring invalid fan speeds raise ServiceValidationError for multiple entity types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add explicit validation on fan speed modes to limit to existing valid modes.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: