Support media player for Shelly Wall Display#168494
Merged
Merged
Conversation
home-assistant
Bot
added
cla-signed
integration: shelly
new-feature
new-platform
Top 100
Contributor
|
Hey there @thecode, @chemelli74, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new media_player platform to the Shelly integration to support media playback control/browsing (intended for Shelly Wall Display RPC devices), and introduces new translated exceptions for unsupported media requests.
Changes:
- Register
Platform.MEDIA_PLAYERfor the Shelly integration. - Add a new
ShellyRpcMediaPlayerentity with playback controls, media browsing, and image handling. - Add new translated exception messages for unsupported media browse/play requests.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
homeassistant/components/shelly/__init__.py |
Enables the Shelly config entry to forward setup for the new media_player platform. |
homeassistant/components/shelly/media_player.py |
Implements the Shelly RPC media player entity, including browse/play and playback state properties. |
homeassistant/components/shelly/strings.json |
Adds new translation keys for media-related exceptions raised by the new platform. |
bieniu
force-pushed
the
shelly-media-player
branch
from
d0cff20 to
f7fa85e
Compare
bieniu
force-pushed
the
shelly-media-player
branch
from
eb490ef to
8135aba
Compare
thecode
added
the
noteworthy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Waiting for: home-assistant-libs/aioshelly#1112Feature request: https://github.com/orgs/home-assistant/discussions/2820
This PR adds a media player platform to the Shelly integration for Shelly Wall Display devices.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: