Skip to content

change unknown to None in Netatmo public#16845

Merged
pvizeli merged 1 commit intodevfrom
netatmo_public
Sep 25, 2018
Merged

change unknown to None in Netatmo public#16845
pvizeli merged 1 commit intodevfrom
netatmo_public

Conversation

@Danielhiversen
Copy link
Copy Markdown
Member

Description:

Fix this comment: #16671 (review) from @MartinHjelmare

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pvizeli pvizeli merged commit 01925fd into dev Sep 25, 2018
@ghost ghost removed the in progress label Sep 25, 2018
@pvizeli pvizeli deleted the netatmo_public branch September 25, 2018 11:41
@GP8x
Copy link
Copy Markdown
Contributor

GP8x commented Sep 25, 2018

Thanks for picking this up. Out of curiosity what is the intended purpose for ‘’’STATE_UNKNOWN’’’ over None ?

@MartinHjelmare
Copy link
Copy Markdown
Member

STATE_UNKNOWN is used by the base entity class and written to the state machine when the entity state property returns None. We should let the core handle it like that.

@GP8x
Copy link
Copy Markdown
Contributor

GP8x commented Sep 25, 2018

Awesome, thanks for the explanation.

@balloob balloob mentioned this pull request Oct 12, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants