Skip to content

Fix shelly test RuntimeWarnings#168380

Merged
thecode merged 1 commit into
home-assistant:devfrom
cdce8p:fix-shelly
Apr 16, 2026
Merged

Fix shelly test RuntimeWarnings#168380
thecode merged 1 commit into
home-assistant:devfrom
cdce8p:fix-shelly

Conversation

@cdce8p
Copy link
Copy Markdown
Member

@cdce8p cdce8p commented Apr 16, 2026

Proposed change

tests/components/shelly/test_config_flow.py::test_bluetooth_flow_abort_cleans_up_ble_connection
  /Library/Frameworks/Python.framework/Versions/3.14/lib/python3.14/unittest/mock.py:495: RuntimeWarning:
    coroutine 'AsyncMockMixin._execute_mock_call' was never awaited
  Coroutine created at (most recent call last)
    ...
    File "/.../homeassistant/components/shelly/config_flow.py", line 1008, in _async_provision_wifi_and_wait_for_zeroconf
      device_info = await validate_input(
    File "/.../homeassistant/components/shelly/config_flow.py", line 180, in validate_input
      rpc_device.xmod_info.get("p") or rpc_device.shelly.get(CONF_MODEL)

tests/components/shelly/test_config_flow.py::test_bluetooth_provision_ble_reconnect_fails_during_ip_fetch
  /Library/Frameworks/Python.framework/Versions/3.14/lib/python3.14/traceback.py:295: RuntimeWarning:
    coroutine 'AsyncMockMixin._execute_mock_call' was never awaited
  Coroutine created at (most recent call last)
    ...
    File "/.../homeassistant/components/shelly/config_flow.py", line 1008, in _async_provision_wifi_and_wait_for_zeroconf
      device_info = await validate_input(
    File "/.../homeassistant/components/shelly/config_flow.py", line 180, in validate_input
      rpc_device.xmod_info.get("p") or rpc_device.shelly.get(CONF_MODEL)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings April 16, 2026 14:43
@home-assistant home-assistant Bot added cla-signed code-quality has-tests integration: shelly small-pr PRs with less than 30 lines. Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage Top 50 Integration is ranked within the top 50 by usage labels Apr 16, 2026
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @bieniu, @thecode, @chemelli74, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of shelly can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign shelly Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Shelly config flow tests to avoid RuntimeWarning: coroutine ... was never awaited by using a shared RPC device mock that provides real dicts for fields accessed synchronously during validation.

Changes:

  • Replace ad-hoc AsyncMock() RPC devices in several BLE provisioning tests with create_mock_rpc_device().
  • Ensure mocked RPC devices expose xmod_info / shelly as dicts so validate_input() can call .get() without creating un-awaited coroutines.

@thecode thecode merged commit 74c62c3 into home-assistant:dev Apr 16, 2026
37 checks passed
@cdce8p cdce8p deleted the fix-shelly branch April 16, 2026 15:45
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed code-owner-approved code-quality has-tests integration: shelly Quality Scale: platinum small-pr PRs with less than 30 lines. Top 50 Integration is ranked within the top 50 by usage Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants