Skip to content

Improve error handling for vacuum clean_area#168177

Merged
arturpragacz merged 4 commits into
home-assistant:devfrom
arturpragacz:vacuum/clean-area-multi-target-error-improvement
Apr 28, 2026
Merged

Improve error handling for vacuum clean_area#168177
arturpragacz merged 4 commits into
home-assistant:devfrom
arturpragacz:vacuum/clean-area-multi-target-error-improvement

Conversation

@arturpragacz
Copy link
Copy Markdown
Member

@arturpragacz arturpragacz commented Apr 14, 2026

Proposed change

Improve error handling for vacuum clean_area.

Improve error handling for vacuum.clean_area by utilising batched entity service call, allowing areas to be validated across all targeted vacuums at once and raising an error when areas are not mapped to any segments on the targeted vacuums.

Requires #168175.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (vacuum) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of vacuum can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign vacuum Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves vacuum.clean_area validation by switching the service implementation to a batched entity-service call so requested areas can be validated across all targeted vacuums, and by introducing a new translated validation error when areas aren’t mapped to any segments on the targeted vacuums.

Changes:

  • Add a batched mode to entity-service registration/calling so a service handler can receive all matched entities at once.
  • Update vacuum.clean_area to run as a batched service handler and raise a new areas_not_mapped validation error when appropriate.
  • Extend vacuum tests and translations to cover the new error path.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/components/vacuum/test_init.py Updates/extends tests for batched clean_area behavior and new validation error.
homeassistant/helpers/service.py Adds batched entity-service execution path and a helper to call methods across multiple entities.
homeassistant/helpers/entity_component.py Plumbs batched through entity-service registration at the component level.
homeassistant/components/vacuum/strings.json Adds translation for the new areas_not_mapped exception message.
homeassistant/components/vacuum/init.py Implements batched clean_area handler and new cross-vacuum area validation.

Comment thread homeassistant/components/vacuum/__init__.py
Comment thread homeassistant/helpers/service.py Outdated
Comment thread homeassistant/helpers/service.py Outdated
Comment thread homeassistant/components/vacuum/__init__.py
@arturpragacz arturpragacz force-pushed the vacuum/clean-area-multi-target-error-improvement branch from cb6029b to be9c287 Compare April 14, 2026 16:00
Copilot AI review requested due to automatic review settings April 16, 2026 16:17
@arturpragacz arturpragacz force-pushed the vacuum/clean-area-multi-target-error-improvement branch from be9c287 to ab67ae9 Compare April 16, 2026 16:17
@arturpragacz arturpragacz marked this pull request as ready for review April 16, 2026 16:17
@arturpragacz arturpragacz requested a review from a team as a code owner April 16, 2026 16:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment thread tests/components/vacuum/test_init.py Outdated
Comment thread tests/components/vacuum/test_init.py
Comment thread homeassistant/components/vacuum/__init__.py
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @arturpragacz 👍

@arturpragacz arturpragacz merged commit d3809dd into home-assistant:dev Apr 28, 2026
48 checks passed
@arturpragacz arturpragacz deleted the vacuum/clean-area-multi-target-error-improvement branch April 28, 2026 07:14
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants