Skip to content

Fix shelly tests - mock async_unload_entry#166851

Merged
frenck merged 1 commit into
home-assistant:devfrom
justanotherariel:3.14.3-fix-shelly-conftest-unload
Mar 30, 2026
Merged

Fix shelly tests - mock async_unload_entry#166851
frenck merged 1 commit into
home-assistant:devfrom
justanotherariel:3.14.3-fix-shelly-conftest-unload

Conversation

@justanotherariel
Copy link
Copy Markdown
Member

Breaking change

Proposed change

Split out from #166683 which tries to fix the flaky tests in the shelly integration. This PR focuses on the mock_setup_entry fixture, which didn't patch async_unload_entry before. This caused an error on test teardown because entry.runtime_data wasn't initialized. entry.runtime_data doesn't exist because flow tests use mock_setup_entry to skip the real integration setup.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Shelly test fixtures to fully stub config entry lifecycle during config flow tests, preventing teardown failures when entry.runtime_data is not initialized.

Changes:

  • Extend the mock_setup_entry fixture to also patch homeassistant.components.shelly.async_unload_entry.
  • Update the fixture docstring to reflect the expanded patching behavior.

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @bieniu, @thecode, @chemelli74, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of shelly can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign shelly Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 30, 2026

Caution

Review failed

An error occurred during the review process. Please try again later.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @justanotherariel 👍

../Frenck

                       

Blogging my personal ramblings at frenck.dev

@frenck frenck merged commit 194485d into home-assistant:dev Mar 30, 2026
59 of 60 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants