Log raw result of configure_reporting() command.#16655
Merged
Danielhiversen merged 1 commit intohome-assistant:devfrom Sep 17, 2018
Merged
Log raw result of configure_reporting() command.#16655Danielhiversen merged 1 commit intohome-assistant:devfrom
Danielhiversen merged 1 commit intohome-assistant:devfrom
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This is an update to PR #16487
Xiaomi devices do not support ZCL configure_reporting command and instead of returning a
ConfigureReportingResponserecord they just fail withUNSUPPORTED_GENERAL_COMMANDso debug logging fails to parse result correctly. Instead we'll print the string representation of the whole response.@damarco can you please retry this PR and let me know if it fixes your issue?
Checklist:
tox. Your PR cannot be merged unless tests pass