Skip to content

Rename humidity.value condition to humidity.is_value#166372

Merged
frenck merged 1 commit into
home-assistant:devfrom
justanotherariel:rename-humidity-conditions
Mar 24, 2026
Merged

Rename humidity.value condition to humidity.is_value#166372
frenck merged 1 commit into
home-assistant:devfrom
justanotherariel:rename-humidity-conditions

Conversation

@justanotherariel
Copy link
Copy Markdown
Member

Breaking change

Proposed change

SSIA - after discord discussion, we decided it should be called .is_value.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

@justanotherariel justanotherariel requested a review from a team as a code owner March 24, 2026 17:58
Copilot AI review requested due to automatic review settings March 24, 2026 17:58
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (humidity) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of humidity can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign humidity Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @justanotherariel 👍

../Frenck

                       

Blogging my personal ramblings at frenck.dev

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames the Humidity integration’s numerical “value” condition key to humidity.is_value to align naming with other “is_*” conditions in the new experimental triggers/conditions system.

Changes:

  • Renamed the condition type from humidity.value to humidity.is_value in the humidity condition platform.
  • Updated the humidity integration’s condition schema/metadata (conditions.yaml, strings.json, icons.json) to the new key.
  • Updated humidity condition tests to use the new condition type string.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/components/humidity/test_condition.py Updates test parametrization to reference humidity.is_value.
homeassistant/components/humidity/condition.py Renames the registered condition key to is_value.
homeassistant/components/humidity/conditions.yaml Renames the condition schema key to is_value.
homeassistant/components/humidity/strings.json Renames the condition translation key to is_value.
homeassistant/components/humidity/icons.json Renames the condition icon key to is_value.

Comment thread homeassistant/components/humidity/conditions.yaml
Comment thread homeassistant/components/humidity/condition.py
@frenck frenck merged commit a19c1a7 into home-assistant:dev Mar 24, 2026
37 checks passed
@frenck frenck removed this from the 2026.4.0b0 milestone Mar 25, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants