Isort preparations#16555
Merged
balloob merged 2 commits intohome-assistant:devfrom Sep 11, 2018
scop:isort-prep
Merged
Conversation
That was a < 3.5 era thing.
To avoid isort moving a top level one around, undesirably broadening its scope.
homeassistant
added
cla-signed
integration: apple_tv
integration: geo_location
integration: google_assistant
integration: rachio
integration: recorder
core
platform: media_player.cast
small-pr
balloob
approved these changes
Sep 11, 2018
Merged
ghost
added
integration: cast
integration: webostv
and removed
platform: media_player.cast
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This takes care of some special cases that would cause undesirable things to happen if one were to run isort over the entire codebase.
The main thing of the typing-in-between commit is the setup.cfg change, the rest in it is just taking care of pylint issues resulting from it as well as removing the in-between newlines where applicable.
FYI @fabaff
Checklist:
tox. Your PR cannot be merged unless tests pass