Wrong camera type & missing sensors when multiple Netatmo camera#16490
Merged
pvizeli merged 1 commit intohome-assistant:devfrom Sep 10, 2018
vikramgorla:dev
Merged
Wrong camera type & missing sensors when multiple Netatmo camera#16490pvizeli merged 1 commit intohome-assistant:devfrom vikramgorla:dev
pvizeli merged 1 commit intohome-assistant:devfrom
vikramgorla:dev
Conversation
…tmo cameras fixed get_camera_type as it was originally not consuming any input, was looping with all cameras and the first camera type was retutned, modified to call cameraType using provided camera name.
homeassistant
added
integration: netatmo
small-pr
Contributor
|
Hi @vikramgorla, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
ghost
added
the
fabaff
changed the title
Member
|
A cleanup would be nice. This class look very wired ⏬ |
pvizeli
approved these changes
Sep 10, 2018
balloob
pushed a commit
that referenced
this pull request
Sep 11, 2018
…tmo cameras (#16490) fixed get_camera_type as it was originally not consuming any input, was looping with all cameras and the first camera type was retutned, modified to call cameraType using provided camera name.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixed an issue with Netatmo discovery where the camera_type (Camera Model) was incorrectly mapped for 2nd and subsequent cameras when their models were different from first camera.
The function get_camera_type was used incorrectly - it was accepting camera name as input but was not used, was always looping across all cameras and returning camera type of first camera as return string.
I suspect that a latent bug exist with another function update_event as it is using self.camera_type which is None, no change in functionality of that event updater with this PR, but has to be fixed later if binary sensors need specific events.
Related issue (if applicable): fixes #16331
Checklist:
tox. Your PR cannot be merged unless tests pass