Skip to content

Make the Qnap sensor more resilient if server is not reachable #16445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabaff merged 5 commits into from
Sep 10, 2018
Merged

Make the Qnap sensor more resilient if server is not reachable #16445

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dc024dd
add CONF_ALLOW_UNREACHABLE option, retry connection if allowed
mrosseel Sep 5, 2018
5ea926b
Merge remote-tracking branch 'upstream/dev' into qnap
mrosseel Sep 5, 2018
1767e47
fix linting errors
mrosseel Sep 5, 2018
c7f3363
Merge remote-tracking branch 'upstream/dev' into qnap
mrosseel Sep 10, 2018
8718e9e
Removing the config option, just using PlatformNotReady
mrosseel Sep 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions homeassistant/components/sensor/qnap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
CONF_HOST, CONF_USERNAME, CONF_PASSWORD, CONF_PORT, CONF_SSL, ATTR_NAME,
CONF_VERIFY_SSL, CONF_TIMEOUT, CONF_MONITORED_CONDITIONS, TEMP_CELSIUS)
from homeassistant.util import Throttle
from homeassistant.exceptions import PlatformNotReady
import homeassistant.helpers.config_validation as cv

REQUIREMENTS = ['qnapstats==0.2.7']
Expand Down Expand Up @@ -107,14 +108,9 @@ def setup_platform(hass, config, add_entities, discovery_info=None):
api = QNAPStatsAPI(config)
api.update()

# QNAP is not available
if not api.data:
hass.components.persistent_notification.create(
'Error: Failed to set up QNAP sensor.<br />'
'Check the logs for additional information. '
'You will need to restart hass after fixing.',
title=NOTIFICATION_TITLE,
notification_id=NOTIFICATION_ID)
return False
raise PlatformNotReady

sensors = []

Expand Down