Skip to content

Adjust openrgb default color mode handling#162650

Merged
epenet merged 1 commit into
devfrom
epenet/20260209-1543
Feb 9, 2026
Merged

Adjust openrgb default color mode handling#162650
epenet merged 1 commit into
devfrom
epenet/20260209-1543

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Feb 9, 2026

Proposed change

Follow-up to #162276
Spotted in #162644

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings February 9, 2026 14:47
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Feb 9, 2026

Hey there @felipecrs, mind taking a look at this pull request as it has been labeled with an integration (openrgb) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of openrgb can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign openrgb Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the OpenRGB light entity’s default color_mode handling to align with recent core light validation changes (follow-up to #162276 / spotted in #162644), avoiding invalid/legacy None color mode handling and ensuring a valid fallback behavior.

Changes:

  • Initialize color_mode with ColorMode.UNKNOWN instead of None.
  • Update the fallback condition to treat ColorMode.UNKNOWN as the “unset” state and default to ColorMode.RGB.

Comment on lines 161 to 199
@@ -194,8 +194,8 @@ def _update_attrs(self) -> None:
# If Off by color, retain previous color mode to avoid changing the UI
color_mode = self._attr_color_mode

if color_mode is None:
# If color mode is still None, default to RGB
if color_mode == ColorMode.UNKNOWN:
# If color mode is still unknown, default to RGB
color_mode = ColorMode.RGB
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change adjusts the fallback from None to ColorMode.UNKNOWN, which affects the initial/off-by-color/off-by-mode paths. There is currently no test asserting that an OpenRGB light starting in Off mode (or Off-by-color) reports valid supported_color_modes (i.e., not including ColorMode.UNKNOWN) and doesn’t trigger light color mode validation warnings. Add a test case covering these states to prevent regressions.

Copilot generated this review using guidance from repository custom instructions.
@epenet epenet merged commit 27d6ae2 into dev Feb 9, 2026
37 of 38 checks passed
@epenet epenet deleted the epenet/20260209-1543 branch February 9, 2026 15:00
@epenet epenet mentioned this pull request Feb 10, 2026
21 tasks
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants