Conversation
homeassistant
added
cla-signed
platform: media_player.sonos
small-pr
ghost
assigned
Kane610
reviewed
Aug 29, 2018
| def device_info(self): | ||
| """Return information about the device.""" | ||
| return { | ||
| 'identifiers': [ |
Member
There was a problem hiding this comment.
Identifiers should be sets with tuples
amelchio
reviewed
Aug 29, 2018
Contributor
amelchio
left a comment
amelchio
left a comment
There was a problem hiding this comment.
I know nothing about device_info itself :)
| (SONOS_DOMAIN, self._unique_id) | ||
| ], | ||
| 'name': self._name, | ||
| 'model': self._model.replace("Sonos ", ""), |
Contributor
There was a problem hiding this comment.
There was a recent firmware change so "Sonos " might not be right for all players (cf. #15604).
On the other hand, Sonos is pretty agressive about updates so maybe it no longer matters.
Member
Author
There was a problem hiding this comment.
If the string is not found, it does nothing 👍
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add device info for Sonos media players.