Skip to content

Fix Plex device method calling itself instead of self._device#16255

Merged
balloob merged 1 commit intohome-assistant:devfrom
Kane610:plex-device-issue
Aug 29, 2018
Merged

Fix Plex device method calling itself instead of self._device#16255
balloob merged 1 commit intohome-assistant:devfrom
Kane610:plex-device-issue

Conversation

@Kane610
Copy link
Copy Markdown
Member

@Kane610 Kane610 commented Aug 29, 2018

Description:

Related issue (if applicable): fixes #16250

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned Kane610 Aug 29, 2018
@ghost ghost added the in progress label Aug 29, 2018
@balloob balloob added this to the 0.77 milestone Aug 29, 2018
@balloob balloob merged commit 63614a4 into home-assistant:dev Aug 29, 2018
@ghost ghost removed the in progress label Aug 29, 2018
@Kane610 Kane610 deleted the plex-device-issue branch August 29, 2018 08:29
@balloob balloob mentioned this pull request Aug 29, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

media_player.plex not working

3 participants