Skip to content

Tweak MFA login flow#16254

Merged
balloob merged 2 commits intohome-assistant:devfrom
awarecan:mfa-translation
Aug 29, 2018
Merged

Tweak MFA login flow#16254
balloob merged 2 commits intohome-assistant:devfrom
awarecan:mfa-translation

Conversation

@awarecan
Copy link
Copy Markdown
Contributor

Description:

Tweak MFA login flow for better user experience. Front end home-assistant/frontend#1608

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@awarecan awarecan added this to the 0.77 milestone Aug 29, 2018
@homeassistant homeassistant added cla-signed core small-pr PRs with less than 30 lines. labels Aug 29, 2018
@ghost ghost assigned awarecan Aug 29, 2018
@ghost ghost added the in progress label Aug 29, 2018
await self._async_load()

# user_input has been validate in caller
# set INPUT_FIELD_CODE as vol.Require is not user friendly
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vol.Required

@balloob balloob merged commit 5635886 into home-assistant:dev Aug 29, 2018
@ghost ghost removed the in progress label Aug 29, 2018
balloob pushed a commit that referenced this pull request Aug 29, 2018
* Tweak MFA login flow

* Fix typo
@balloob balloob mentioned this pull request Aug 29, 2018
@awarecan awarecan deleted the mfa-translation branch August 30, 2018 01:10
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
* Tweak MFA login flow

* Fix typo
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants