Inconsistent entity_id when multiple sensors#16205
Merged
balloob merged 3 commits intohome-assistant:devfrom Aug 26, 2018
Merged
Inconsistent entity_id when multiple sensors#16205balloob merged 3 commits intohome-assistant:devfrom
balloob merged 3 commits intohome-assistant:devfrom
Conversation
I am submitting a change to fix a [bug](home-assistant#16204) for when there are several sensors for the same hostname. For example I want to track my IPv4 and IPv6 address. It creates two entities that regularly switch ids based on the order they get initialized. To fix this I comform to the way other componnents have addressed the issue by adding an optional `name` attribute.
homeassistant
added
cla-signed
platform: sensor.dnsip
small-pr
ghost
added
the
houndci-bot
reviewed
Aug 26, 2018
| def async_update(self): | ||
| """Get the current DNS IP address for hostname.""" | ||
| response = yield from self.resolver.query(self._name, self.querytype) | ||
| response = yield from self.resolver.query(self.hostname, self.querytype) |
There was a problem hiding this comment.
line too long (80 > 79 characters)
grea09
added a commit
to grea09/home-assistant.github.io
that referenced
this pull request
Aug 26, 2018
In order to fix a [bug](home-assistant/core#16204) a new field needs to be introduced. Pull request : home-assistant/core#16205
houndci-bot
reviewed
Aug 26, 2018
| def async_update(self): | ||
| """Get the current DNS IP address for hostname.""" | ||
| response = yield from self.resolver.query(self._name, self.querytype) | ||
| response = yield from self.resolver.query(self.hostname, |
balloob
approved these changes
Aug 26, 2018
Member
|
Great! |
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* Inconsistent entity_id when multiple sensors I am submitting a change to fix a [bug](home-assistant#16204) for when there are several sensors for the same hostname. For example I want to track my IPv4 and IPv6 address. It creates two entities that regularly switch ids based on the order they get initialized. To fix this I comform to the way other componnents have addressed the issue by adding an optional `name` attribute. * Line too long * Removing trailing whitespace
Merged
|
This is a breaking change. my sensor was named sensor.myipopendnscom |
grea09
added a commit
to grea09/home-assistant.github.io
that referenced
this pull request
Sep 25, 2018
Adressing [comment](home-assistant/core#16205 (comment)) to reflect actual behaviour.
2 tasks
fabaff
pushed a commit
to home-assistant/home-assistant.io
that referenced
this pull request
Sep 25, 2018
Adressing [comment](home-assistant/core#16205 (comment)) to reflect actual behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am submitting a change to fix a bug for when there are several sensors for the same hostname.
Description:
For example I want to track my IPv4 and IPv6 address. It creates two entities that regularly switch ids based on the order they get initialized.
To fix this I comform to the way other componnents have addressed the issue by adding an optional
nameattribute.Related issue (if applicable): fixes #16204
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: