Skip to content

Default load trusted_network auth provider if configured trusted networks#16184

Merged
balloob merged 1 commit intohome-assistant:devfrom
awarecan:auto-config-trusted-networks-auth-prov
Aug 25, 2018
Merged

Default load trusted_network auth provider if configured trusted networks#16184
balloob merged 1 commit intohome-assistant:devfrom
awarecan:auto-config-trusted-networks-auth-prov

Conversation

@awarecan
Copy link
Copy Markdown
Contributor

Description:

Default load trusted_network auth provider if user configured trusted networks

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@awarecan awarecan requested a review from a team as a code owner August 24, 2018 22:26
@homeassistant homeassistant added core small-pr PRs with less than 30 lines. cla-signed labels Aug 24, 2018
@ghost ghost assigned awarecan Aug 24, 2018
@ghost ghost added the in progress label Aug 24, 2018
@awarecan awarecan added this to the 0.77 milestone Aug 24, 2018
@balloob
Copy link
Copy Markdown
Member

balloob commented Aug 25, 2018

I don't know if we should do this, as I actually wanted to put in a PR to migrate the trusted networks config to the trusted network auth provider config before release.

Although this will be less painful migration.

@balloob balloob merged commit 26a485d into home-assistant:dev Aug 25, 2018
@ghost ghost removed the in progress label Aug 25, 2018
@balloob
Copy link
Copy Markdown
Member

balloob commented Aug 25, 2018

Doing this for now.

In the future we'll do it slowly:

  • allow configuring trusted networks under auth provider. If no config in auth provider, check for config under HTTP. If found, use that and print warning that configuration should be put under auth provider
  • drop support for config under HTTP

@balloob balloob mentioned this pull request Aug 29, 2018
@awarecan awarecan deleted the auto-config-trusted-networks-auth-prov branch August 30, 2018 01:10
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants