Skip to content

Add 'moon_phase' to Dark Sky sensor #16179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bachya merged 1 commit into from
Aug 24, 2018
Merged

Add 'moon_phase' to Dark Sky sensor #16179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions homeassistant/components/sensor/darksky.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,12 @@

DEFAULT_NAME = 'Dark Sky'

DEPRECATED_SENSOR_TYPES = {'apparent_temperature_max',
'apparent_temperature_min',
'temperature_max',
'temperature_min'}
DEPRECATED_SENSOR_TYPES = {
'apparent_temperature_max',
'apparent_temperature_min',
'temperature_max',
'temperature_min',
}

# Sensor types are defined like so:
# Name, si unit, us unit, ca unit, uk unit, uk2 unit
Expand Down Expand Up @@ -125,6 +127,8 @@
UNIT_UV_INDEX, UNIT_UV_INDEX, UNIT_UV_INDEX,
UNIT_UV_INDEX, UNIT_UV_INDEX, 'mdi:weather-sunny',
['currently', 'hourly', 'daily']],
'moon_phase': ['Moon Phase', None, None, None, None, None,
'mdi:weather-night', ['daily']],
}

CONDITION_PICTURES = {
Expand Down Expand Up @@ -203,7 +207,7 @@ def setup_platform(hass, config, add_entities, discovery_info=None):
sensors = []
for variable in config[CONF_MONITORED_CONDITIONS]:
if variable in DEPRECATED_SENSOR_TYPES:
_LOGGER.warning("Monitored condition %s is deprecated.",
_LOGGER.warning("Monitored condition %s is deprecated",
variable)
sensors.append(DarkSkySensor(forecast_data, variable, name))
if forecast is not None and 'daily' in SENSOR_TYPES[variable][7]:
Expand Down Expand Up @@ -316,7 +320,8 @@ def update(self):
'apparent_temperature_max',
'apparent_temperature_high',
'precip_intensity_max',
'precip_accumulation']):
'precip_accumulation',
'moon_phase']):
self.forecast_data.update_daily()
daily = self.forecast_data.data_daily
if self.type == 'daily_summary':
Expand Down Expand Up @@ -407,7 +412,7 @@ def _update(self):
self._api_key, self.latitude, self.longitude, units=self.units,
lang=self.language)
except (ConnectError, HTTPError, Timeout, ValueError) as error:
_LOGGER.error("Unable to connect to Dark Sky. %s", error)
_LOGGER.error("Unable to connect to Dark Sky: %s", error)
self.data = None
self.unit_system = self.data and self.data.json['flags']['units']

Expand Down