Generic Thermostat: add support for climate.turn_on/climate.turn_off#16080
Merged
Danielhiversen merged 5 commits intohome-assistant:devfrom Sep 2, 2018
Merged
Conversation
Contributor
|
For the mode_auto part, please take a look #15678 |
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
…ome-assistant#16080) * Added async_turn_on and async_turn_off implementations. * Added turning on/off tests to generic thermostat * style * style * style
Merged
ghost
added
integration: generic_thermostat
and removed
platform: climate.generic_thermostat
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Added support for turning a
generic_thermostatdevice on and off viaclimate.turn_onandclimate.turn_offservices. This makes certain automations a lot easier to write.Turning it on would be a bit ambiguous (and require looking up its state prior to being turned off), but luckily, it currently supports only a single operation mode in addition to OFF: either COOL or HEAT. So the
async_turn_onmethod simply switches the operation mode to the first mode in the operation_list, which is, by definition, the only supported mode.In the future, if support for multiple modes is added (as has been attempted before, with an AUTO mode), the logic will have to be revised.
Checklist:
tox. Your PR cannot be merged unless tests pass