Add quality scale to Tesla Fleet integration #160475
+87
−1
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| rules: | ||
|
|
||
| # Bronze | ||
| action-setup: | ||
| status: exempt | ||
| comment: Integration does not register custom service actions in async_setup. | ||
| appropriate-polling: done | ||
| brands: done | ||
| common-modules: done | ||
| config-flow-test-coverage: | ||
| status: todo | ||
| comment: Review feedback requested stronger config flow test coverage for domain registration errors and removal of unnecessary translation mocking where possible. | ||
| config-flow: | ||
| status: todo | ||
| comment: Review feedback questioned whether the custom OAuth flow implementation can be simplified, including whether `CONFIG_SCHEMA` and the custom `OAuth2FlowHandler` are both needed. | ||
| dependency-transparency: done | ||
| docs-actions: | ||
| status: exempt | ||
| comment: Integration does not provide custom service actions beyond standard entity services. | ||
| docs-high-level-description: done | ||
| docs-installation-instructions: done | ||
| docs-removal-instructions: done | ||
| entity-event-setup: done | ||
| entity-unique-id: done | ||
| has-entity-name: done | ||
| runtime-data: done | ||
| test-before-configure: done | ||
| test-before-setup: done | ||
| unique-config-entry: done | ||
| # Silver | ||
| action-exceptions: done | ||
| config-entry-unloading: done | ||
| docs-configuration-parameters: done | ||
| docs-installation-parameters: done | ||
| entity-unavailable: done | ||
| integration-owner: done | ||
| log-when-unavailable: | ||
| status: todo | ||
| comment: Coordinator raises UpdateFailed but does not implement the full log-once pattern (log when becoming unavailable, log when recovering). | ||
| parallel-updates: done | ||
| reauthentication-flow: done | ||
|
Comment on lines
+1
to
+40
There was a problem hiding this comment. Consider using the shorthand format (e.g., |
||
| test-coverage: | ||
| status: todo | ||
| comment: Review feedback requested test cleanup follow-ups, including patching API objects where they are used, preferring direct asserts over the `test_climate_offline` snapshot where appropriate, removing an unnecessary `async_setup_component(...)`, and avoiding direct `entry.runtime_data` assertions in unload tests. | ||
| # Gold | ||
| devices: done | ||
| diagnostics: done | ||
| discovery-update-info: | ||
| status: exempt | ||
| comment: Integration does not implement device discovery mechanisms. | ||
| discovery: | ||
| status: exempt | ||
| comment: Tesla Fleet API requires OAuth authentication and cannot be automatically discovered. | ||
|
Comment on lines
+50
to
+52
Member
There was a problem hiding this comment. Can we detect a tesla on a network? Would it make sense to autodetect the integration then
Contributor
Author
There was a problem hiding this comment. No, only on Bluetooth, but I want to save that for the Tesla Bluetooth integration. |
||
| docs-data-update: done | ||
| docs-examples: | ||
| status: todo | ||
| comment: Documentation includes NGINX configuration examples but lacks automation use case examples. | ||
| docs-known-limitations: done | ||
| docs-supported-devices: done | ||
| docs-supported-functions: done | ||
| docs-troubleshooting: done | ||
| docs-use-cases: | ||
| status: todo | ||
| comment: Documentation does not include explicit use case scenarios. | ||
| dynamic-devices: done | ||
| entity-category: done | ||
| entity-device-class: done | ||
| entity-disabled-by-default: done | ||
| entity-translations: done | ||
| exception-translations: | ||
| status: todo | ||
| comment: PR already raised to fix these | ||
| icon-translations: done | ||
| reconfiguration-flow: | ||
| status: todo | ||
| comment: Integration does not implement async_step_reconfigure for updating settings without removal. | ||
| repair-issues: | ||
| status: exempt | ||
| comment: Integration does not have scenarios requiring user-actionable repair issues. | ||
| stale-devices: | ||
| status: todo | ||
| comment: Integration does not automatically remove devices that are no longer present in the Tesla account. | ||
| # Platinum tier | ||
| async-dependency: done | ||
| inject-websession: done | ||
| strict-typing: | ||
| status: todo | ||
| comment: Integration is not yet registered in .strict-typing file and needs comprehensive type annotation review. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -937,7 +937,6 @@ class Rule: | |
| "telnet", | ||
| "temper", | ||
| "template", | ||
| "tesla_wall_connector", | ||
|
Comment on lines
937
to
940
There was a problem hiding this comment. The PR description states it should "Add quality_scale: bronze to manifest.json" and includes tracking for higher tiers. However, the manifest.json file is not modified in this diff. Additionally, the validation logic at lines 2242-2249 of this file requires that if a quality_scale field is added to the manifest, tesla_fleet must be removed from INTEGRATIONS_WITHOUT_SCALE in this file. The diff shows tesla_fleet still in INTEGRATIONS_WITHOUT_SCALE at line 1939. These changes appear to be missing from the PR. |
||
| "thermobeacon", | ||
| "thermopro", | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need
CONFIG_SCHEMA = cv.config_entry_only_config_schema(DOMAIN)right?