Update neato to support new StateVacuumDevice#16035
Merged
MartinHjelmare merged 5 commits intohome-assistant:devfrom Aug 18, 2018
Merged
Update neato to support new StateVacuumDevice#16035MartinHjelmare merged 5 commits intohome-assistant:devfrom
MartinHjelmare merged 5 commits intohome-assistant:devfrom
Conversation
homeassistant
added
platform: vacuum.neato
small-pr
ghost
added
the
2 tasks
| return self._clean_state | ||
|
|
||
| @property | ||
| def state_attributes(self): |
Member
There was a problem hiding this comment.
Please also fix this old code and use device_state_attributes here instead. State attributes will be updated with device_state_attributes in the base entity.
| def turn_on(self, **kwargs): | ||
| def start(self): | ||
| """Turn the vacuum on and start cleaning.""" | ||
| self._clean_state = STATE_CLEANING |
Member
There was a problem hiding this comment.
update will be called directly after the method call when handling the service call, so it's better to let update handle the state update.
Member
Author
|
Thanks for the review @MartinHjelmare :) I have made the requested changes, removed a couple more updates that were not necessary. Fixed resume cleaning since I forgot to add it back and adjusted the docs. All changes were tested and verified locally. |
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* Update neato to support new vacuum states * Remove changes submitted in error * Lint * Review comments and fix resume cleaning * Lint
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the neato vacuum component to support the latest states from PR #15573
Architecture issue: home-assistant/architecture#29
This is also a breaking change as the component no longer uses STATE_ON and STATE_OFF.
Also removes any functions related to ToggleEntity, which results in the following services no longer working:
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6036
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: