Skip to content

Fix geizhals price parsing #15990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 10 commits into from
Aug 27, 2018
Merged

Fix geizhals price parsing #15990

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
acae9cc
fix geizhals price parsing
JulianKahnert Aug 15, 2018
e2ffe42
Fix lint issue
fabaff Aug 16, 2018
ab7986a
switch to the geizhals pypi package
JulianKahnert Aug 16, 2018
eda5c1b
throttle updates
JulianKahnert Aug 16, 2018
b949fc5
update geizhals version
JulianKahnert Aug 17, 2018
828d556
initialize empty device
JulianKahnert Aug 17, 2018
86b7b34
minor changes to trigger another TravisCI test
JulianKahnert Aug 23, 2018
556a35e
device => _device
JulianKahnert Aug 23, 2018
d20403d
bump geizhals version
JulianKahnert Aug 24, 2018
ed1beed
Merge branch 'dev' into patch-2
JulianKahnert Aug 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions homeassistant/components/sensor/geizhals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,21 +128,21 @@ def update(self):
timeout=1)
soup = bs4.BeautifulSoup(request.text, 'html.parser')

# parse name
raw = soup.find_all('span', attrs={'itemprop': 'name'})
self.device_name = raw[1].string
# Parse name
raw = soup.find('h1', attrs={'class': 'gh-headline'})

@balloob balloob Aug 16, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be extracted from Home Assistant and into a separate Python library. We will not be able to accept any changes to this platform until this is fixed.

@JulianKahnert JulianKahnert Aug 16, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your comments @MartinHjelmare and @balloob ! I will create a separate library for that.

self.device_name = raw.string

# parse prices
# Parse prices
prices = []
for tmp in soup.find_all('span', attrs={'class': 'gh_price'}):
for tmp in soup.select('div.offer__price .gh_price'):
matches = re.search(self.regex, tmp.string)
raw = '{}.{}'.format(matches.group(1),
matches.group(2))
prices += [float(raw)]
prices.sort()
self.prices = prices[1:]

# parse unit
# Parse unit
price_match = soup.find('span', attrs={'class': 'gh_price'})
matches = re.search(r'€|£|PLN', price_match.string)
self.unit_of_measurement = matches.group()