Skip to content

Address reviewer feedback on exception handling in hikvision#159752

Merged
MartinHjelmare merged 2 commits into
home-assistant:devfrom
ptarjan:claude/hikvision-reviewer-feedback-012bm7PWpikgSddSEixptrqe
Dec 27, 2025
Merged

Address reviewer feedback on exception handling in hikvision#159752
MartinHjelmare merged 2 commits into
home-assistant:devfrom
ptarjan:claude/hikvision-reviewer-feedback-012bm7PWpikgSddSEixptrqe

Conversation

@ptarjan
Copy link
Copy Markdown
Contributor

@ptarjan ptarjan commented Dec 25, 2025

Discussion from #158279 by @MartinHjelmare

Breaking change

Proposed change

  • Remove exception logging for known RequestException
  • Add broad Exception handler with _LOGGER.exception
  • Remove warning log for YAML import (signaled via issue)
  • Remove unused init_integration fixture
  • Add unknown error/abort translations
  • Add tests for unknown exception handling

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

- Remove exception logging for known RequestException
- Add broad Exception handler with _LOGGER.exception
- Remove warning log for YAML import (signaled via issue)
- Remove unused init_integration fixture
- Add unknown error/abort translations
- Add tests for unknown exception handling
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @mezz64, mind taking a look at this pull request as it has been labeled with an integration (hikvision) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hikvision can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign hikvision Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown
Contributor

@home-assistant home-assistant Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @claude

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft December 25, 2025 21:59
Match scaffold template pattern by showing the config flow
can recover from an unknown exception error.
@ptarjan ptarjan force-pushed the claude/hikvision-reviewer-feedback-012bm7PWpikgSddSEixptrqe branch from 7a4ab95 to 1c10579 Compare December 25, 2025 22:02
@ptarjan ptarjan marked this pull request as ready for review December 25, 2025 22:05
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare
Copy link
Copy Markdown
Member

You should move the bullets under the correct header in the PR description.

@MartinHjelmare
Copy link
Copy Markdown
Member

And fill in the checklist appropriately.

@MartinHjelmare MartinHjelmare marked this pull request as draft December 25, 2025 22:54
@ptarjan ptarjan marked this pull request as ready for review December 25, 2025 22:58
@MartinHjelmare MartinHjelmare changed the title Address reviewer feedback on exception handling Address reviewer feedback on exception handling in hikvision Dec 27, 2025
@MartinHjelmare MartinHjelmare merged commit d9fe37e into home-assistant:dev Dec 27, 2025
36 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants