Skip to content

Use runtime_data in VeSync#159720

Merged
joostlek merged 4 commits into
home-assistant:devfrom
cdnninja:runtime
Dec 29, 2025
Merged

Use runtime_data in VeSync#159720
joostlek merged 4 commits into
home-assistant:devfrom
cdnninja:runtime

Conversation

@cdnninja
Copy link
Copy Markdown
Contributor

@cdnninja cdnninja commented Dec 24, 2025

Proposed change

Convert to config_entry.runtime_data for vesync to reach bronze. #156663

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @markperdue, @webdjoe, @TheGardenMonkey, @iprak, @SapuSeven, mind taking a look at this pull request as it has been labeled with an integration (vesync) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of vesync can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign vesync Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

await manager.update()
await manager.check_firmware()

config_entry.runtime_data = VeSyncDataCoordinator(hass, config_entry, manager)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason we are not building the manager inside the coordinator now and to https://github.com/cdnninja/core/blob/5614518710c77b1e190f313e944dcf03c72b5fb9/homeassistant/components/vesync/__init__.py#L60-L65 within _async_setup of the coordinator

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could move it in. Only thought is that #156663 (comment) comment is referencing adding a second coordinator. Both will need access to the manager. Thoughts?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it probably doesn’t make sense

Copy link
Copy Markdown
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also extend the config entry type with the typeslot, so we can type entry.runtime_data

@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft December 25, 2025 00:10
@cdnninja
Copy link
Copy Markdown
Contributor Author

Typing added and replied to the other comment.

@cdnninja cdnninja marked this pull request as ready for review December 26, 2025 20:03
@home-assistant home-assistant Bot requested a review from joostlek December 26, 2025 20:03
@joostlek joostlek changed the title Vesync config_entry.runtime_data Use runtime_data in VeSync Dec 29, 2025
# Conflicts:
#	tests/components/vesync/test_init.py
@joostlek joostlek merged commit 96d1e3d into home-assistant:dev Dec 29, 2025
32 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants