Skip to content

Fix Roborock repair issue behavior#159718

Merged
thecode merged 1 commit into
home-assistant:devfrom
allenporter:roborock-verify-api
Dec 24, 2025
Merged

Fix Roborock repair issue behavior#159718
thecode merged 1 commit into
home-assistant:devfrom
allenporter:roborock-verify-api

Conversation

@allenporter
Copy link
Copy Markdown
Contributor

Clear repair issues related to connectivity if the device later becomes reachable locally. We only preserve the issue if the device has never ben reachable locally.

Proposed change

Clear repair issues related to connectivity if the device later becomes reachable locally. We only preserve the issue if the device has never ben reachable locally. This root cause where this happens commonly is because of a race that will also be fixed separately.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Clear repair issues related to connectivity if the device later becomes reachable locally. We only preserve the issue if the device has never ben reachable locally.
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the behavior of Roborock repair issues related to cloud-only connectivity. The integration now tracks whether a device has ever connected locally and clears connectivity repair issues once local connection is established. If the device later becomes cloud-only again, the repair issue is not recreated since the device has demonstrated local connectivity capability.

Key changes:

  • Added persistent tracking of local connectivity status via _has_connected_locally flag
  • Modified _verify_api() to only show repair issues for devices that have never connected locally
  • Added _verify_api() call at the start of _async_update_data() to check connectivity on each update

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
homeassistant/components/roborock/coordinator.py Added _has_connected_locally flag to track if device has ever connected locally; updated _verify_api() logic to clear and prevent recreating repair issues once local connection is established; added _verify_api() call in _async_update_data()
tests/components/roborock/test_init.py Added comprehensive test covering the scenario where a device starts cloud-only, becomes locally reachable (issue cleared), then returns to cloud-only (issue not recreated)

@thecode thecode merged commit 83d4f8e into home-assistant:dev Dec 24, 2025
41 of 42 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants