Fix Roborock repair issue behavior#159718
Merged
Merged
Conversation
Clear repair issues related to connectivity if the device later becomes reachable locally. We only preserve the issue if the device has never ben reachable locally.
Contributor
|
Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the behavior of Roborock repair issues related to cloud-only connectivity. The integration now tracks whether a device has ever connected locally and clears connectivity repair issues once local connection is established. If the device later becomes cloud-only again, the repair issue is not recreated since the device has demonstrated local connectivity capability.
Key changes:
- Added persistent tracking of local connectivity status via
_has_connected_locallyflag - Modified
_verify_api()to only show repair issues for devices that have never connected locally - Added
_verify_api()call at the start of_async_update_data()to check connectivity on each update
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
homeassistant/components/roborock/coordinator.py |
Added _has_connected_locally flag to track if device has ever connected locally; updated _verify_api() logic to clear and prevent recreating repair issues once local connection is established; added _verify_api() call in _async_update_data() |
tests/components/roborock/test_init.py |
Added comprehensive test covering the scenario where a device starts cloud-only, becomes locally reachable (issue cleared), then returns to cloud-only (issue not recreated) |
thecode
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clear repair issues related to connectivity if the device later becomes reachable locally. We only preserve the issue if the device has never ben reachable locally.
Proposed change
Clear repair issues related to connectivity if the device later becomes reachable locally. We only preserve the issue if the device has never ben reachable locally. This root cause where this happens commonly is because of a race that will also be fixed separately.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: