Bump python-roborock to 3.21.1#159660
Merged
Merged
Conversation
home-assistant
Bot
added
cla-signed
dependency
Contributor
|
Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps the python-roborock dependency from version 3.20.1 to 3.21.0 to incorporate upstream fixes that enable Home Assistant to properly handle unauthorized MQTT sessions.
Key Changes:
- Updated python-roborock dependency version across all requirement files
- The integration already has exception handling in place for
MqttSessionUnauthorized(imported from the library and handled in__init__.py)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| requirements_test_all.txt | Updated python-roborock test dependency to 3.21.0 |
| requirements_all.txt | Updated python-roborock runtime dependency to 3.21.0 |
| homeassistant/components/roborock/manifest.json | Updated python-roborock requirement to 3.21.0 in integration manifest |
The changes look good! This is a straightforward dependency bump that:
- ✅ Consistently updates the version across all three required files
- ✅ Uses a valid semantic version format
- ✅ The integration code already has proper exception handling for
MqttSessionUnauthorized(lines 98-102 in__init__.py) - ✅ No additional code changes are needed since the exception handling was already in place
allenporter
changed the title
TheJulianJES
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Bump python-roborock to 3.21.1
Changes: Python-roborock/python-roborock@v3.20.1...v3.21.1
Includes fixes to allow home assistant to handle unauthorized mqtt sessions.
Type of change
Additional information
[code:135] Not authorized#159444Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: