Skip to content

Fix Ecoforest unknown alarm translation key#159594

Merged
jbouwh merged 1 commit into
home-assistant:devfrom
maylikenoother:fix-ecoforest-unknown-alarm
Dec 22, 2025
Merged

Fix Ecoforest unknown alarm translation key#159594
jbouwh merged 1 commit into
home-assistant:devfrom
maylikenoother:fix-ecoforest-unknown-alarm

Conversation

@maylikenoother
Copy link
Copy Markdown
Contributor

@maylikenoother maylikenoother commented Dec 22, 2025

Proposed change

Fix a typo in the Ecoforest integration translation key for the alarm enum state.
This ensures the "Unknown alarm" state is translated correctly.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue:
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @pjanuario, mind taking a look at this pull request as it has been labeled with an integration (ecoforest) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ecoforest can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign ecoforest Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restore the PR template

@home-assistant home-assistant Bot marked this pull request as draft December 22, 2025 13:35
@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@jbouwh
Copy link
Copy Markdown
Contributor

jbouwh commented Dec 22, 2025

Restored PR template

@jbouwh jbouwh marked this pull request as ready for review December 22, 2025 20:01
@home-assistant home-assistant Bot requested a review from joostlek December 22, 2025 20:01
@jbouwh jbouwh dismissed joostlek’s stale review December 22, 2025 20:08

stale. Template restored

@jbouwh jbouwh merged commit 0b20417 into home-assistant:dev Dec 22, 2025
36 checks passed
@jbouwh jbouwh added this to the 2025.12.5 milestone Dec 22, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants