Skip to content

Pooldose action exceptions#159572

Merged
joostlek merged 8 commits into
home-assistant:devfrom
lmaertin:pooldose-action-exceptions
Dec 29, 2025
Merged

Pooldose action exceptions#159572
joostlek merged 8 commits into
home-assistant:devfrom
lmaertin:pooldose-action-exceptions

Conversation

@lmaertin
Copy link
Copy Markdown
Contributor

@lmaertin lmaertin commented Dec 22, 2025

Breaking change

Proposed change

Add action exception handling; centralized in entity.py for all write entities.
If approved integration gets 'silver' quality.

I decided to go for this approach to avoid a lot of redundant code in each (write) platform for handling ServiceValidationErrors. If not following the logic of seperated platforms, I can move the functionality to the platforms as well. Need advice from reviewer.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Comment thread homeassistant/components/pooldose/entity.py Outdated
Comment thread tests/components/pooldose/test_action_errors.py Outdated
@home-assistant home-assistant Bot marked this pull request as draft December 23, 2025 12:51
@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Comment thread tests/components/pooldose/test_number.py Outdated
@home-assistant home-assistant Bot marked this pull request as draft December 28, 2025 18:31
@lmaertin lmaertin marked this pull request as ready for review December 28, 2025 23:30
@home-assistant home-assistant Bot requested a review from joostlek December 28, 2025 23:30
@joostlek joostlek merged commit 9631528 into home-assistant:dev Dec 29, 2025
36 checks passed
@lmaertin lmaertin deleted the pooldose-action-exceptions branch December 29, 2025 12:54
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants