Redact additional unnecessary diagnostic fields#159546
Conversation
|
Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull request overview
This PR enhances privacy protection in the Roborock integration by expanding the list of fields that are redacted from diagnostic data. The changes prevent exposure of user-identifiable and authentication-related information when users share diagnostics.
Key changes:
- Expands the
TO_REDACT_CONFIGlist to include 8 additional fields:h,k,s,u(IoT service authentication fields within therriotobject),avatarurl,nickname,tuyaUuid, andextra - Updates test snapshots to reflect that these fields are now properly redacted as
**REDACTED**instead of showing actual values
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
homeassistant/components/roborock/diagnostics.py |
Expands TO_REDACT_CONFIG list to redact 8 additional sensitive fields (user profile data and IoT authentication credentials) |
tests/components/roborock/snapshots/test_diagnostics.ambr |
Updates test snapshot to verify that avatarurl, nickname, and rriot authentication fields (h, k, s, u) are now properly redacted |
The changes appropriately protect user privacy by redacting fields containing personal identifiers (avatar URLs, nicknames) and authentication credentials (IoT service tokens). The test snapshots correctly reflect these redactions. No issues found.
Proposed change
Redact additional unnecessary diagnostic fields
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: