Support KNX scene entity configuration from UI#159494
Merged
Merged
Conversation
Contributor
|
Hey there @Julius2342, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
8 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds UI configuration support for KNX scene entities, enabling users to create and manage scene entities through the Home Assistant UI instead of only through YAML configuration.
Key changes:
- Refactored scene entity classes to support both YAML and UI configuration patterns
- Added scene entity schema and validation for UI-based configuration
- Implemented comprehensive test coverage for UI entity creation and loading
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
homeassistant/components/knx/scene.py |
Refactored entity classes: split original KNXScene into base _KnxScene, KnxYamlScene for YAML config, and new KnxUiScene for UI config; updated async_setup_entry to handle both configuration sources |
homeassistant/components/knx/const.py |
Added SceneConf class with SCENE_NUMBER constant and added Platform.SCENE to SUPPORTED_PLATFORMS_UI set |
homeassistant/components/knx/schema.py |
Updated YAML schema to use SceneConf.SCENE_NUMBER constant for consistency with other platforms |
homeassistant/components/knx/storage/const.py |
Added CONF_GA_SCENE constant for scene group address storage key |
homeassistant/components/knx/storage/entity_store_schema.py |
Added SCENE_KNX_SCHEMA with validation for scene group address and scene number (1-64 range) |
homeassistant/components/knx/strings.json |
Added user-facing text for scene entity configuration including descriptions and labels for group address and scene number fields |
tests/components/knx/test_scene.py |
Added test_scene_ui_create and test_scene_ui_load tests to verify UI entity creation and storage loading functionality |
tests/components/knx/fixtures/config_store_scene.json |
Added test fixture with scene configuration data for storage loading tests |
tests/components/knx/snapshots/test_websocket.ambr |
Added snapshot test data for scene entity schema validation via websocket API |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
joostlek
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Support KNX scene entity configuration from UI
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: