Skip to content

Support KNX scene entity configuration from UI#159494

Merged
joostlek merged 2 commits into
devfrom
knx-scene-ui
Dec 23, 2025
Merged

Support KNX scene entity configuration from UI#159494
joostlek merged 2 commits into
devfrom
knx-scene-ui

Conversation

@farmio
Copy link
Copy Markdown
Member

@farmio farmio commented Dec 20, 2025

Proposed change

Support KNX scene entity configuration from UI

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @Julius2342, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration (knx) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of knx can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign knx Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds UI configuration support for KNX scene entities, enabling users to create and manage scene entities through the Home Assistant UI instead of only through YAML configuration.

Key changes:

  • Refactored scene entity classes to support both YAML and UI configuration patterns
  • Added scene entity schema and validation for UI-based configuration
  • Implemented comprehensive test coverage for UI entity creation and loading

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
homeassistant/components/knx/scene.py Refactored entity classes: split original KNXScene into base _KnxScene, KnxYamlScene for YAML config, and new KnxUiScene for UI config; updated async_setup_entry to handle both configuration sources
homeassistant/components/knx/const.py Added SceneConf class with SCENE_NUMBER constant and added Platform.SCENE to SUPPORTED_PLATFORMS_UI set
homeassistant/components/knx/schema.py Updated YAML schema to use SceneConf.SCENE_NUMBER constant for consistency with other platforms
homeassistant/components/knx/storage/const.py Added CONF_GA_SCENE constant for scene group address storage key
homeassistant/components/knx/storage/entity_store_schema.py Added SCENE_KNX_SCHEMA with validation for scene group address and scene number (1-64 range)
homeassistant/components/knx/strings.json Added user-facing text for scene entity configuration including descriptions and labels for group address and scene number fields
tests/components/knx/test_scene.py Added test_scene_ui_create and test_scene_ui_load tests to verify UI entity creation and storage loading functionality
tests/components/knx/fixtures/config_store_scene.json Added test fixture with scene configuration data for storage loading tests
tests/components/knx/snapshots/test_websocket.ambr Added snapshot test data for scene entity schema validation via websocket API

Comment thread homeassistant/components/knx/scene.py Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@joostlek joostlek merged commit c0fa6ad into dev Dec 23, 2025
36 checks passed
@joostlek joostlek deleted the knx-scene-ui branch December 23, 2025 17:56
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants