Improve date handling in UniFi Protect media source#159491
Merged
joostlek merged 8 commits intoDec 23, 2025
Merged
Conversation
- Replace manual month increment logic with calendar.monthrange() - Simplify _format_duration() using divmod pattern - Normalize _get_month_start_end() to use second=0 - Fix month iteration to use >= instead of > for same-month handling - Add comprehensive tests for date calculations across all month types
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves date handling in the UniFi Protect media source component by refactoring manual date arithmetic with cleaner, more maintainable approaches using Python's standard library functions.
Key Changes:
- Replaces error-prone manual month increment logic with
calendar.monthrange()for accurate month boundary calculations - Refactors
_format_duration()to use thedivmodpattern for cleaner time component extraction - Fixes month iteration logic to correctly handle same-month scenarios by changing comparison from
>to>=
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| homeassistant/components/unifiprotect/media_source.py | Implements date calculation improvements: adds monthrange import, simplifies _format_duration() with divmod, normalizes _get_month_start_end() to use second=0, fixes month end calculation in _build_month() and _build_days() using monthrange, and corrects same-month iteration logic |
| tests/components/unifiprotect/test_media_source.py | Adds comprehensive parameterized test for date calculations covering various month types including leap years and December edge case, but contains a critical bug in the test implementation |
joostlek
requested changes
Dec 23, 2025
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
joostlek
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: