Skip to content

Fix mysensors connection task blocking setup #15938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 2 commits into from
Aug 16, 2018
Merged

Fix mysensors connection task blocking setup #15938

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5aa6b1d
Fix mysensors connection task blocking setup
MartinHjelmare Aug 12, 2018
eecb648
Use done instead of cancelled
MartinHjelmare Aug 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion homeassistant/components/mysensors/gateway.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,12 +186,16 @@ def _discover_mysensors_platform(hass, platform, new_devices):

async def _gw_start(hass, gateway):
"""Start the gateway."""
# Don't use hass.async_create_task to avoid holding up setup indefinitely.
connect_task = hass.loop.create_task(gateway.start())

@callback
def gw_stop(event):
"""Trigger to stop the gateway."""
hass.async_add_job(gateway.stop())
if not connect_task.done():
connect_task.cancel()

await gateway.start()
hass.bus.async_listen_once(EVENT_HOMEASSISTANT_STOP, gw_stop)
if gateway.device == 'mqtt':
# Gatways connected via mqtt doesn't send gateway ready message.
Expand Down