Do not trigger reauth for addon in Music Assistant#159372
Merged
arturpragacz merged 1 commit intoDec 18, 2025
Merged
Conversation
Contributor
|
Hey there @music-assistant, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents the Music Assistant integration from triggering a reauthentication flow when running as a Home Assistant addon and encountering authentication errors. Instead, it waits for addon discovery to provide the correct token and reload the config entry automatically, since users cannot manually reauthenticate when the integration runs as an addon.
Key Changes:
- Adds logic to detect addon mode and raise
ConfigEntryErrorinstead ofConfigEntryAuthFailedfor authentication failures - Includes
ConfigEntryState.SETUP_IN_PROGRESSin the list of states that trigger config entry reload during addon discovery - Adds test coverage for the new addon authentication behavior
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| homeassistant/components/music_assistant/init.py | Added check to prevent reauth flow for addons by raising ConfigEntryError instead of ConfigEntryAuthFailed when homeassistant_addon is true |
| homeassistant/components/music_assistant/config_flow.py | Added ConfigEntryState.SETUP_IN_PROGRESS to the list of states that trigger reload during hassio discovery |
| tests/components/music_assistant/test_init.py | Added test to verify no reauth is triggered for addons and cleaned up comment formatting in existing test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Do not trigger reauth for addon in Music Assistant.
When running as addon, there is no possibility for users to reauthenticate manually.
Instead we should wait until addon discovery provides us with the right token and reloads the config entry.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: