Skip to content

Do not trigger reauth for addon in Music Assistant#159372

Merged
arturpragacz merged 1 commit into
home-assistant:devfrom
arturpragacz:music_assistant/do-not-trigger-reauth-for-addon
Dec 18, 2025
Merged

Do not trigger reauth for addon in Music Assistant#159372
arturpragacz merged 1 commit into
home-assistant:devfrom
arturpragacz:music_assistant/do-not-trigger-reauth-for-addon

Conversation

@arturpragacz
Copy link
Copy Markdown
Member

Proposed change

Do not trigger reauth for addon in Music Assistant.

When running as addon, there is no possibility for users to reauthenticate manually.
Instead we should wait until addon discovery provides us with the right token and reloads the config entry.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @music-assistant, mind taking a look at this pull request as it has been labeled with an integration (music_assistant) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of music_assistant can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign music_assistant Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@arturpragacz arturpragacz added this to the 2025.12.4 milestone Dec 18, 2025
Copy link
Copy Markdown
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @arturpragacz !

@arturpragacz arturpragacz merged commit 5401072 into home-assistant:dev Dec 18, 2025
38 of 40 checks passed
@arturpragacz arturpragacz deleted the music_assistant/do-not-trigger-reauth-for-addon branch December 18, 2025 15:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prevents the Music Assistant integration from triggering a reauthentication flow when running as a Home Assistant addon and encountering authentication errors. Instead, it waits for addon discovery to provide the correct token and reload the config entry automatically, since users cannot manually reauthenticate when the integration runs as an addon.

Key Changes:

  • Adds logic to detect addon mode and raise ConfigEntryError instead of ConfigEntryAuthFailed for authentication failures
  • Includes ConfigEntryState.SETUP_IN_PROGRESS in the list of states that trigger config entry reload during addon discovery
  • Adds test coverage for the new addon authentication behavior

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
homeassistant/components/music_assistant/init.py Added check to prevent reauth flow for addons by raising ConfigEntryError instead of ConfigEntryAuthFailed when homeassistant_addon is true
homeassistant/components/music_assistant/config_flow.py Added ConfigEntryState.SETUP_IN_PROGRESS to the list of states that trigger reload during hassio discovery
tests/components/music_assistant/test_init.py Added test to verify no reauth is triggered for addons and cleaned up comment formatting in existing test

Comment thread homeassistant/components/music_assistant/__init__.py
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants