Skip to content

KNX Fan: Add support for switch addresses#159367

Merged
joostlek merged 2 commits into
devfrom
knx-fan-switch
Dec 19, 2025
Merged

KNX Fan: Add support for switch addresses#159367
joostlek merged 2 commits into
devfrom
knx-fan-switch

Conversation

@farmio
Copy link
Copy Markdown
Member

@farmio farmio commented Dec 18, 2025

Proposed change

This adds support for knx fan entities that either only support switching (on/off binary) or support switching in addition to setting a speed. The actuators default turn-on speed will be respected then.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @Julius2342, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration (knx) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of knx can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign knx Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for KNX fan entities that use switch addresses for on/off control, either as the sole control method or in combination with speed control. This allows fans to respect the actuator's default turn-on speed when no specific percentage is provided.

Key changes:

  • Refactored async_turn_on and async_turn_off to delegate to the underlying xknx device's turn_on() and turn_off() methods instead of using set_speed()
  • Made speed control optional in the schema, requiring at least one of switch or speed configuration
  • Updated supported_features to conditionally include SET_SPEED only when speed control is initialized

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
homeassistant/components/knx/fan.py Refactored turn on/off methods to use device-level commands, added support for switch addresses in UI fan initialization, made speed features conditional
homeassistant/components/knx/storage/entity_store_schema.py Updated schema to make both switch and speed optional with validation requiring at least one
homeassistant/components/knx/strings.json Added UI labels and descriptions for the new switch group address field
tests/components/knx/test_fan.py Added test case for switch-only fan configuration with state verification
tests/components/knx/snapshots/test_websocket.ambr Updated snapshot to reflect new optional switch field in schema

Comment thread tests/components/knx/test_fan.py
@farmio farmio marked this pull request as draft December 18, 2025 15:21
@farmio farmio marked this pull request as ready for review December 18, 2025 19:15
@joostlek joostlek merged commit 1c3492b into dev Dec 19, 2025
36 checks passed
@joostlek joostlek deleted the knx-fan-switch branch December 19, 2025 14:37
jcisio pushed a commit to jcisio/home-assistant-core that referenced this pull request Dec 19, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants