Skip to content

Bump momonga to 0.3.0#159350

Merged
zweckj merged 1 commit into
home-assistant:devfrom
SeraphicCorp:momonga-0.3.0
Dec 19, 2025
Merged

Bump momonga to 0.3.0#159350
zweckj merged 1 commit into
home-assistant:devfrom
SeraphicCorp:momonga-0.3.0

Conversation

@SeraphicRav
Copy link
Copy Markdown
Contributor

@SeraphicRav SeraphicRav commented Dec 18, 2025

Breaking change

Proposed change

Updating Momonga to add more supported devices
nbtk/momonga@v0.2.0...v0.3.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Member

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft December 18, 2025 10:19
@SeraphicRav
Copy link
Copy Markdown
Contributor Author

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

Sorry, added a link to the change logs:
nbtk/momonga@v0.2.0...v0.3.0

@SeraphicRav SeraphicRav marked this pull request as ready for review December 19, 2025 05:22
@home-assistant home-assistant Bot requested a review from edenhaus December 19, 2025 05:22
@zweckj zweckj merged commit 4d5b8c4 into home-assistant:dev Dec 19, 2025
122 of 124 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 20, 2025
@SeraphicRav SeraphicRav deleted the momonga-0.3.0 branch December 20, 2025 14:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants