Skip to content

Add missing strings for Shelly voltmeter sensor #159332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zweckj merged 1 commit into from
Dec 18, 2025
+6 −0
Merged

Add missing strings for Shelly voltmeter sensor #159332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions homeassistant/components/shelly/strings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,6 +537,12 @@
"voltmeter_value": {
"name": "Voltmeter value"
},
"voltmeter_value_with_channel_name": {
"name": "Voltmeter value {channel_name}"
},
"voltmeter_with_channel_name": {
"name": "Voltmeter {channel_name}"
Comment on lines +541 to +544
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming pattern for these translation strings is inconsistent with the established pattern in this file. All other _with_channel_name entries place the channel name placeholder at the beginning (e.g., "{channel_name} pulse counter value", "{channel_name} power factor"), but these new entries place it at the end ("Voltmeter value {channel_name}", "Voltmeter {channel_name}").

For consistency, these should be:

  • "voltmeter_value_with_channel_name": "name": "{channel_name} voltmeter value"
  • "voltmeter_with_channel_name": "name": "{channel_name} voltmeter"
Suggested change
"name": "Voltmeter value {channel_name}"
},
"voltmeter_with_channel_name": {
"name": "Voltmeter {channel_name}"
"name": "{channel_name} voltmeter value"
},
"voltmeter_with_channel_name": {
"name": "{channel_name} voltmeter"

Copilot uses AI. Check for mistakes.
},
"water_consumption": {
"name": "Water consumption"
},
Expand Down
Loading