Skip to content

Add Hikvision integration quality scale#159252

Merged
joostlek merged 4 commits into
home-assistant:devfrom
ptarjan:claude/update-hikvision-docs-vxbf7
Feb 23, 2026
Merged

Add Hikvision integration quality scale#159252
joostlek merged 4 commits into
home-assistant:devfrom
ptarjan:claude/update-hikvision-docs-vxbf7

Conversation

@ptarjan
Copy link
Copy Markdown
Contributor

@ptarjan ptarjan commented Dec 17, 2025

Update the quality_scale from legacy to bronze and add the quality_scale.yaml file tracking the status of all bronze rules.

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @mezz64, mind taking a look at this pull request as it has been labeled with an integration (hikvision) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hikvision can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign hikvision Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@epenet epenet changed the title Upgrade Hikvision integration quality scale to bronze Add Hikvision integration quality scale Dec 17, 2025
epenet
epenet previously requested changes Dec 17, 2025
Copy link
Copy Markdown
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you actually check all the rules against the IQS, or are you relying 100% on claude?

You cannot update the quality_scale until all corresponding rules have been resolved.

Also, CI is failing

@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@ptarjan
Copy link
Copy Markdown
Contributor Author

ptarjan commented Dec 17, 2025

Did you actually check all the rules against the IQS, or are you relying 100% on claude?

Not 100%, lets say 90%. I looked at the list and it seemed reasonable after claude made it. It seems you have a skill that lets claude build these lists so with such dedication to supporting claude here I thought that was reasonable. Was it not?

You cannot update the quality_scale until all corresponding rules have been resolved.

They should be, it was missing home-assistant/home-assistant.io#42617

Also, CI is failing

fixed

@ptarjan ptarjan force-pushed the claude/update-hikvision-docs-vxbf7 branch from 736e930 to c32ccf1 Compare December 20, 2025 06:17
@ptarjan ptarjan marked this pull request as ready for review December 20, 2025 06:17
@ptarjan ptarjan requested a review from a team as a code owner December 20, 2025 06:17
@home-assistant home-assistant Bot requested a review from epenet December 20, 2025 06:17
Comment thread homeassistant/components/hikvision/quality_scale.yaml Outdated
Comment thread homeassistant/components/hikvision/quality_scale.yaml Outdated
Comment thread homeassistant/components/hikvision/quality_scale.yaml
@ptarjan ptarjan force-pushed the claude/update-hikvision-docs-vxbf7 branch 3 times, most recently from 2db6d3c to dad1102 Compare February 8, 2026 05:30
@ptarjan ptarjan force-pushed the claude/update-hikvision-docs-vxbf7 branch from dad1102 to d54da1a Compare February 13, 2026 06:57
Copilot AI review requested due to automatic review settings February 23, 2026 20:33
common-modules: done
config-flow-test-coverage: done
config-flow: done
dependency-transparency: done
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The library is not built in the CI, so it doesn't fulfill this rule

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the Hikvision integration from legacy status to Bronze tier in the Home Assistant quality scale system. The PR removes the integration from the legacy list and adds comprehensive quality scale tracking documentation.

Changes:

  • Removed "hikvision" from INTEGRATIONS_WITHOUT_SCALE list in quality scale validation script
  • Removed quality_scale: "legacy" from manifest.json (Bronze is default tier)
  • Added quality_scale.yaml tracking Bronze, Silver, Gold, and Platinum rule compliance status

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
script/hassfest/quality_scale.py Removed "hikvision" from the legacy integrations list
homeassistant/components/hikvision/quality_scale.yaml Added new quality scale tracking file with rule status for all tiers
homeassistant/components/hikvision/manifest.json Removed legacy quality_scale designation

Comment thread homeassistant/components/hikvision/quality_scale.yaml Outdated
Comment thread homeassistant/components/hikvision/quality_scale.yaml Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 23, 2026 20:42
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@joostlek joostlek merged commit bae4de3 into home-assistant:dev Feb 23, 2026
29 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants