Add Hikvision integration quality scale#159252
Conversation
|
Hey there @mezz64, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
epenet
left a comment
There was a problem hiding this comment.
Did you actually check all the rules against the IQS, or are you relying 100% on claude?
You cannot update the quality_scale until all corresponding rules have been resolved.
Also, CI is failing
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
1a739c9 to
76d4d18
Compare
76d4d18 to
d0453ca
Compare
Not 100%, lets say 90%. I looked at the list and it seemed reasonable after claude made it. It seems you have a skill that lets claude build these lists so with such dedication to supporting claude here I thought that was reasonable. Was it not?
They should be, it was missing home-assistant/home-assistant.io#42617
fixed |
736e930 to
c32ccf1
Compare
2db6d3c to
dad1102
Compare
dad1102 to
d54da1a
Compare
| common-modules: done | ||
| config-flow-test-coverage: done | ||
| config-flow: done | ||
| dependency-transparency: done |
There was a problem hiding this comment.
The library is not built in the CI, so it doesn't fulfill this rule
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Hikvision integration from legacy status to Bronze tier in the Home Assistant quality scale system. The PR removes the integration from the legacy list and adds comprehensive quality scale tracking documentation.
Changes:
- Removed "hikvision" from
INTEGRATIONS_WITHOUT_SCALElist in quality scale validation script - Removed
quality_scale: "legacy"from manifest.json (Bronze is default tier) - Added quality_scale.yaml tracking Bronze, Silver, Gold, and Platinum rule compliance status
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| script/hassfest/quality_scale.py | Removed "hikvision" from the legacy integrations list |
| homeassistant/components/hikvision/quality_scale.yaml | Added new quality scale tracking file with rule status for all tiers |
| homeassistant/components/hikvision/manifest.json | Removed legacy quality_scale designation |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Update the quality_scale from legacy to bronze and add the quality_scale.yaml file tracking the status of all bronze rules.
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: