Pooldose: Add select platform#159240
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a select platform to the pooldose integration, introducing 8 select entities for configuring pool device settings such as water meter units, flow rate units, and dosing types/methods for pH, ORP, and chlorine systems. The implementation includes unit conversion between Home Assistant's display units (e.g., m³) and the API's internal values (e.g., m3), comprehensive test coverage with 9 test cases, and proper translations with icons.
Key Changes
- Added select platform with 8 configurable entities for pool device settings
- Implemented unit conversion logic using a new
REVERSE_UNIT_MAPPINGdictionary for translating HA units to API values - Refactored sensor platform naming from
use_dynamic_unittouse_unit_conversionfor consistency
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
homeassistant/components/pooldose/select.py |
New select platform implementation with 8 entity descriptions and unit conversion support |
homeassistant/components/pooldose/const.py |
Added REVERSE_UNIT_MAPPING for HA-to-API unit conversion and updated comment clarity |
homeassistant/components/pooldose/sensor.py |
Renamed use_dynamic_unit to use_unit_conversion for consistent terminology |
homeassistant/components/pooldose/__init__.py |
Registered SELECT platform in PLATFORMS list |
homeassistant/components/pooldose/strings.json |
Added translations for all 8 select entities with state mappings |
homeassistant/components/pooldose/icons.json |
Added icon mappings for all select entities |
tests/components/pooldose/test_select.py |
Comprehensive test suite with 9 tests covering entity creation, state changes, unavailability, and unit conversion |
tests/components/pooldose/snapshots/test_select.ambr |
Snapshot data for select entity validation |
tests/components/pooldose/fixtures/instantvalues.json |
Added fixture data for all 8 select entities |
tests/components/pooldose/conftest.py |
Added set_select mock method to support testing |
8 tasks
joostlek
requested changes
Dec 18, 2025
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
joostlek
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
This PR adds a select platform to the pooldose integration with 8 select entities for configuring pool device settings.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: