Skip to content

Sonos increase wait for groups timeout#159108

Merged
zweckj merged 1 commit into
home-assistant:devfrom
PeteRager:sonos-wait-timeout
Dec 15, 2025
Merged

Sonos increase wait for groups timeout#159108
zweckj merged 1 commit into
home-assistant:devfrom
PeteRager:sonos-wait-timeout

Conversation

@PeteRager
Copy link
Copy Markdown
Contributor

Proposed change

Increase the timeout when waiting for grouping to complete (media_player.join, media_player.unjoin) as the current timeout may be insufficient when the integration is running in polling mode. In PR #145602 the warning message was changed to a HomeAssitantError which is now making the insufficient timeout more noticeable.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @jjlawren, mind taking a look at this pull request as it has been labeled with an integration (sonos) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sonos can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign sonos Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@zweckj zweckj added this to the 2025.12.4 milestone Dec 15, 2025
@zweckj zweckj merged commit 1114ce8 into home-assistant:dev Dec 15, 2025
36 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 16, 2025
@PeteRager PeteRager deleted the sonos-wait-timeout branch December 23, 2025 21:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants