Sonos fix media player join to avoid race condition#159106
Merged
Merged
Conversation
Contributor
|
Hey there @jjlawren, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
joostlek
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
When joining speakers using media_player.join the integration sends the join command to each speaker and waits with a timeout for the speakers to reach the desired group state. Each individual speakers responds with one or more zone group state (ZGS) messages. When there are a large number of speakers (like 7); sometimes the ZGS messages from the speakers arrive in incorrect order and the final state (all speakers are grouped) gets overwritten with an intermediate state (some speakers are grouped) and then the wait times out.
This situation likely always existed. With the change in #145602 replacing the warning messages with a HomeAssistantError the situation is now being noticed by users.
The change is to make the joining process deterministic by joining one speaker at a time; and waiting for the speaker to be joined before proceeding to the next one.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: