Skip to content

Misc cleanups #15907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Danielhiversen merged 2 commits into from
Aug 10, 2018
+2 −3
Merged

Misc cleanups #15907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d207a6
device_tracker.huawei_router: Pylint logging-not-lazy fix
scop Aug 9, 2018
2929dea
sensor.irish_rail_transport: Clean up redundant self.info test
scop Aug 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions homeassistant/components/device_tracker/huawei_router.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,7 @@ def _update_info(self):
active_clients = [client for client in data if client.state]
self.last_results = active_clients

# pylint: disable=logging-not-lazy
_LOGGER.debug("Active clients: " + "\n"
_LOGGER.debug("Active clients: %s", "\n"
.join((client.mac + " " + client.name)
for client in active_clients))
return True
Expand Down
2 changes: 1 addition & 1 deletion homeassistant/components/sensor/irish_rail_transport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ def update(self):
ATTR_TRAIN_TYPE: train.get('type')}
self.info.append(train_data)

if not self.info or not self.info:
if not self.info:
self.info = self._empty_train_data()

def _empty_train_data(self):
Expand Down