Fix slow event state updates for remote calendar#159058
Merged
Merged
Conversation
Contributor
|
Hey there @Thomas55555, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a performance issue in the remote_calendar integration where updating the calendar entity state was taking over 1 second, causing Home Assistant to log slow update warnings. The fix aligns the remote_calendar implementation with the pattern already used in local_calendar.
Key changes:
- Eliminated redundant
Timelineobject creation and storage by caching the next event directly - Changed the
eventproperty from computing the next event on-demand to returning a pre-computed cached value - Modified
async_updateto compute and store the nextCalendarEventdirectly instead of storing an intermediateTimelineobject
Thomas55555
approved these changes
Dec 15, 2025
zweckj
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix slow event state updates for remote calendar that currently log the following error.
This is similar to other fixes to local calendar in the past.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: