Skip to content

Bump aioasuswrt to 1.5.4#159038

Merged
TheJulianJES merged 1 commit into
home-assistant:devfrom
upsuper-forks:aioasuswrt-1.5.4
Dec 15, 2025
Merged

Bump aioasuswrt to 1.5.4#159038
TheJulianJES merged 1 commit into
home-assistant:devfrom
upsuper-forks:aioasuswrt-1.5.4

Conversation

@upsuper
Copy link
Copy Markdown
Contributor

@upsuper upsuper commented Dec 14, 2025

Proposed change

Bump aioasuswrt to 1.5.4 changelog

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings December 14, 2025 20:19
@home-assistant home-assistant Bot added bugfix cla-signed dependency Pull requests marked as a dependency upgrade integration: asuswrt small-pr PRs with less than 30 lines. labels Dec 14, 2025
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @kennedyshead, @ollo69, @Vaskivskyi, mind taking a look at this pull request as it has been labeled with an integration (asuswrt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of asuswrt can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign asuswrt Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the aioasuswrt library dependency from version 1.5.3 to 1.5.4 to incorporate bug fixes from the upstream library. This is a straightforward dependency upgrade that updates the version reference across all required files without requiring any code changes to the integration itself.

Key changes:

  • Updated aioasuswrt dependency from 1.5.3 to 1.5.4 in all dependency files

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
homeassistant/components/asuswrt/manifest.json Updated aioasuswrt requirement from 1.5.3 to 1.5.4
requirements_all.txt Updated aioasuswrt version from 1.5.3 to 1.5.4 in the complete requirements list
requirements_test_all.txt Updated aioasuswrt version from 1.5.3 to 1.5.4 in the test requirements list

The changes are straightforward and properly update all three locations where the aioasuswrt version is referenced. The version bump is consistent across all files, and no code changes are needed in the integration itself as this is a minor bugfix release in the upstream library. The integration properly imports and uses the library through its bridge classes, and the tests don't hardcode any version references, so everything should work correctly with the updated dependency.

Copy link
Copy Markdown
Member

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheJulianJES
Copy link
Copy Markdown
Member

#158882, which introduced the temporary fix, is tagged for 2025.12.4, so tagging this for that patch release as well.

@TheJulianJES TheJulianJES added this to the 2025.12.4 milestone Dec 15, 2025
@TheJulianJES TheJulianJES merged commit e58fc69 into home-assistant:dev Dec 15, 2025
73 checks passed
@upsuper upsuper deleted the aioasuswrt-1.5.4 branch December 15, 2025 00:19
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix cherry-picked cla-signed dependency Pull requests marked as a dependency upgrade integration: asuswrt small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants