Skip to content

Some typing related fixes #15899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 2 commits into from
Aug 9, 2018
+4 −4
Merged

Some typing related fixes #15899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9752116
Fix FlowManager.async_init handler type
scop Aug 6, 2018
057b624
Mark pip_kwargs return type hint as Any-valued dict
scop Aug 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions homeassistant/data_entry_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import logging
import uuid
import voluptuous as vol
from typing import Dict, Any, Callable, List, Optional # noqa pylint: disable=unused-import
from typing import Dict, Any, Callable, Hashable, List, Optional # noqa pylint: disable=unused-import
from .core import callback, HomeAssistant
from .exceptions import HomeAssistantError

Expand Down Expand Up @@ -49,7 +49,7 @@ def async_progress(self) -> List[Dict]:
'source': flow.source,
} for flow in self._progress.values()]

async def async_init(self, handler: Callable, *, context: Dict = None,
async def async_init(self, handler: Hashable, *, context: Dict = None,
data: Any = None) -> Any:
"""Start a configuration flow."""
flow = await self._async_create_flow(
Expand Down
4 changes: 2 additions & 2 deletions homeassistant/requirements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from functools import partial
import logging
import os
from typing import List, Dict, Optional
from typing import Any, Dict, List, Optional

import homeassistant.util.package as pkg_util
from homeassistant.core import HomeAssistant
Expand Down Expand Up @@ -37,7 +37,7 @@ async def async_process_requirements(hass: HomeAssistant, name: str,
return True


def pip_kwargs(config_dir: Optional[str]) -> Dict[str, str]:
def pip_kwargs(config_dir: Optional[str]) -> Dict[str, Any]:
"""Return keyword arguments for PIP install."""
kwargs = {
'constraints': os.path.join(os.path.dirname(__file__), CONSTRAINT_FILE)
Expand Down