Skip to content

Remove ALLOW_EXTRA from Telegram bot action schema#158886

Merged
MartinHjelmare merged 7 commits into
home-assistant:devfrom
hanwg:remove-allow-extra
Dec 17, 2025
Merged

Remove ALLOW_EXTRA from Telegram bot action schema#158886
MartinHjelmare merged 7 commits into
home-assistant:devfrom
hanwg:remove-allow-extra

Conversation

@hanwg
Copy link
Copy Markdown
Contributor

@hanwg hanwg commented Dec 13, 2025

Breaking change

ALLOW_EXTRA has been removed from the service schema for Telegram bot.
Only users who have used undefined parameters for Telegram bot actions are affected.
Affected users should remove such parameters from their automations/scripts.

Supported parameters can be found in the Telegram bot notification actions.

Proposed change

Remove ALLOW_EXTRA from service schema.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Contributor

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seams alright. Maybe mark as breaking?

Comment thread homeassistant/components/telegram_bot/__init__.py
@home-assistant home-assistant Bot marked this pull request as draft December 15, 2025 10:39
@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@MartinHjelmare
Copy link
Copy Markdown
Member

Please add a breaking change paragraph in the PR description and explain what users need to do to cope with the change. Most users should not be affected if they have followed the docs.

@hanwg hanwg marked this pull request as ready for review December 16, 2025 12:31
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked all the service action schemas and compared them with the user docs.

Comment thread homeassistant/components/telegram_bot/__init__.py
Comment thread homeassistant/components/telegram_bot/__init__.py
Comment thread homeassistant/components/telegram_bot/__init__.py Outdated
@MartinHjelmare MartinHjelmare marked this pull request as draft December 17, 2025 13:01
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hanwg hanwg marked this pull request as ready for review December 17, 2025 14:04
@MartinHjelmare MartinHjelmare merged commit c418d97 into home-assistant:dev Dec 17, 2025
36 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants