Add monitored conditions for Unifi device_tracker#15888
Merged
MartinHjelmare merged 3 commits intohome-assistant:devfrom Aug 13, 2018
Merged
Add monitored conditions for Unifi device_tracker#15888MartinHjelmare merged 3 commits intohome-assistant:devfrom
MartinHjelmare merged 3 commits intohome-assistant:devfrom
Conversation
ghost
added
the
This was referenced Aug 8, 2018
| vol.Optional(CONF_DETECTION_TIME, default=DEFAULT_DETECTION_TIME): vol.All( | ||
| cv.time_period, cv.positive_timedelta), | ||
| vol.Optional(CONF_MONITORED_CONDITIONS): | ||
| vol.All(cv.ensure_list, [cv.string]), |
Member
There was a problem hiding this comment.
There should be a list of accepted conditions that we validate against here. Please look at sensor platforms that use monitored conditions for examples.
Member
Author
There was a problem hiding this comment.
Added a list of available attributes as requested
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* Add support for monitored_conditions for attributes * Update unifi tests * Add list of available attrs
Contributor
|
I know this has been merged but will this work with unifi_direct_ap? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR supersedes #15711
Adds a monitored_conditions config option to the Unifi device_tracker to pick and chose what extended attributes to keep from the giant list returned by the Unifi controller. Defaults to no extra attributes.
This is technically a breaking change from the current behavior.
Related issue (if applicable): fixes #14745
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5977
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: